netdev
[Top] [All Lists]

Re: [patch 2.4] back port msleep(), msleep_interruptible()

To: maximilian attems <janitor@xxxxxxxxxxxxxx>
Subject: Re: [patch 2.4] back port msleep(), msleep_interruptible()
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Sat, 30 Oct 2004 18:41:10 -0400
Cc: Margit Schubert-While <margitsw@xxxxxxxxxxx>, Nishanth Aravamudan <nacc@xxxxxxxxxx>, hvr@xxxxxxx, mcgrof@xxxxxxxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxx, prism54-devel@xxxxxxxxxxx, netdev@xxxxxxxxxxx, Domen Puncer <domen@xxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20041030222228.GB1456@xxxxxxx>
References: <20040923221303.GB13244@xxxxxxxxxx> <20040923221303.GB13244@xxxxxxxxxx> <5.1.0.14.2.20040924074745.00b1cd40@xxxxxxxxxxxxxxx> <415CD9D9.2000607@xxxxxxxxx> <20041030222228.GB1456@xxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
maximilian attems wrote:
diff -puN include/linux/delay.h~add-msleep-2.4 include/linux/delay.h
--- a/include/linux/delay.h~add-msleep-2.4      2004-10-30 22:48:46.000000000 
+0200
+++ b/include/linux/delay.h     2004-10-30 22:48:46.000000000 +0200
@@ -34,4 +34,12 @@ extern unsigned long loops_per_jiffy;
        ({unsigned long msec=(n); while (msec--) udelay(1000);}))
 #endif
+void msleep(unsigned int msecs);
+unsigned long msleep_interruptible(unsigned int msecs);
+
+static inline void ssleep(unsigned int seconds)
[...]
+static inline unsigned int jiffies_to_msecs(const unsigned long j)

+static inline unsigned int jiffies_to_usecs(const unsigned long j)

+static inline unsigned long msecs_to_jiffies(const unsigned int m)


I'm pretty sure more than one of these symbols clashes with a symbol defined locally in a driver. I like the patch but we can't apply it until the impact on existing code is evaluated.

        Jeff



<Prev in Thread] Current Thread [Next in Thread>