| To: | Al Viro <viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: net: generic netdev_ioaddr |
| From: | "Pekka J Enberg" <penberg@xxxxxxxxxxxxxx> |
| Date: | Fri, 29 Oct 2004 21:50:20 +0300 |
| Cc: | davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20041029131607.GU24336@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <1099044244.9566.0.camel@localhost> <20041029131607.GU24336@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Hi,
Al Viro writes: NAK. ->base_addr casting is a Bad Idea(tm) and natsemi "solution" isn't(thanks for spotting that crap in natsemi, though; will fix...)Note that there is no such thing as "generic IO base address" - it _is_ private and in the best case current ->base_addr is a scratch register probably used for something vaguely connected with some IO, but it's really up to driver... Yup, I thought about that after I sent the patch. However, as it stands now, many network drivers use netdev->base_addr for just that. Perhaps it should be nuked completely instead? Pekka |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH netdev-2.6 7/10] ixgb: Replace kmalloc with vmalloc to allocate driver local data structures, William Lee Irwin III |
|---|---|
| Next by Date: | Re: net: generic netdev_ioaddr, Krzysztof Halasa |
| Previous by Thread: | Re: [RFC][PATCH 0/3] net: generic netdev_ioaddr, Al Viro |
| Next by Thread: | Re: net: generic netdev_ioaddr, Krzysztof Halasa |
| Indexes: | [Date] [Thread] [Top] [All Lists] |