netdev
[Top] [All Lists]

Re: [PATCH netdev-2.6 7/10] ixgb: Replace kmalloc with vmalloc to alloca

To: William Lee Irwin III <wli@xxxxxxxxxxxxxx>
Subject: Re: [PATCH netdev-2.6 7/10] ixgb: Replace kmalloc with vmalloc to allocate driver local data structures
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Fri, 29 Oct 2004 14:26:37 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx>, netdev <netdev@xxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>
In-reply-to: <20041029173636.GB12934@xxxxxxxxxxxxxx>
References: <468F3FDA28AA87429AD807992E22D07E0312853C@orsmsx408> <20041029130817.GA12301@xxxxxxxxxxxxx> <418277B7.7000705@xxxxxxxxx> <20041029173636.GB12934@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
William Lee Irwin III wrote:
vmalloc is relatively highly penalized. For instance, global TLB
flushes associated with vfree() and so on. Aggregate vmallocspace
limitations are a big concern. I probably wouldn't use vmallocspace
for much besides infrequent allocations, e.g. things allocated during
driver initialization. One per driver instance won't really hurt much
because vmallocspace limits prevent large numbers of drivers from being
simultaneously loaded as it stands now anyway.


That's precisely what we're contemplating -- a once per driver allocation that remains static for the entire driver runtime (descriptors)

        Jeff



<Prev in Thread] Current Thread [Next in Thread>