netdev
[Top] [All Lists]

Re: [patch 2/9] use mmiowb in tg3.c

To: akpm@xxxxxxxx
Subject: Re: [patch 2/9] use mmiowb in tg3.c
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 28 Oct 2004 16:42:58 -0700
Cc: jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, akpm@xxxxxxxx, jbarnes@xxxxxxxxxxxx, gnb@xxxxxxx, jbarnes@xxxxxxx
In-reply-to: <200410280721.i9S7Ld907983@xxxxxxxxxxxxx>
References: <200410280721.i9S7Ld907983@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 28 Oct 2004 00:19:40 -0700
akpm@xxxxxxxx wrote:

> From: Jesse Barnes <jbarnes@xxxxxxxxxxxx>
> 
> This patch originally from Greg Banks.  Some parts of the tg3 driver depend
> on PIO writes arriving in order.  This patch ensures that in two key places
> using the new mmiowb macro.  This not only prevents bugs (the queues can be
> corrupted), but is much faster than ensuring ordering using PIO reads
> (which involve a few round trips to the target bus on some platforms).
> 
> Arthur has another patch that uses mmiowb in tg3 that he posted earlier as
> well.
> 
> Signed-off-by: Greg Banks <gnb@xxxxxxx>
> Signed-off-by: Jesse Barnes <jbarnes@xxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxx>

Ok, applied.

<Prev in Thread] Current Thread [Next in Thread>