| To: | netdev@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH][ATM]: don't leak skb on as_indicate failure; don't wakeup twice on as_close |
| From: | "chas williams (contractor)" <chas@xxxxxxxxxxxxxxxx> |
| Date: | Wed, 27 Oct 2004 10:32:54 -0400 |
| Cc: | davem@xxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
please apply to 2.6.
thanks!
Signed-off-by: Chas Williams <chas@xxxxxxxxxxxxxxxx>
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/10/27 09:58:17-04:00 chas@xxxxxxxxxxxxxxxxxxxxxx
# [ATM]: don't leak skb on as_indicate failure; don't wakeup twice on as_close
#
# net/atm/signaling.c
# 2004/10/27 09:58:00-04:00 chas@xxxxxxxxxxxxxxxxxxxxxx +3 -1
# [ATM]: don't leak skb on as_indicate failure; don't wakeup twice on as_close
#
diff -Nru a/net/atm/signaling.c b/net/atm/signaling.c
--- a/net/atm/signaling.c 2004-10-27 10:30:12 -04:00
+++ b/net/atm/signaling.c 2004-10-27 10:30:12 -04:00
@@ -136,6 +136,7 @@
if (vcc->sk->sk_ack_backlog ==
vcc->sk->sk_max_ack_backlog) {
sigd_enq(NULL,as_reject,vcc,NULL,NULL);
+ dev_kfree_skb(skb);
goto as_indicate_complete;
}
vcc->sk->sk_ack_backlog++;
@@ -148,7 +149,7 @@
case as_close:
set_bit(ATM_VF_RELEASED,&vcc->flags);
vcc_release_async(vcc, msg->reply);
- break;
+ goto out;
case as_modify:
modify_qos(vcc,msg);
break;
@@ -163,6 +164,7 @@
return -EINVAL;
}
vcc->sk->sk_state_change(vcc->sk);
+out:
dev_kfree_skb(skb);
return 0;
}
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] net: 8139too netdev_priv conversion, Steffen Klassert |
|---|---|
| Next by Date: | Re: [PATCH, TAKE 2] [IPV6] XFRM: extract xfrm_lookup() from ip6_dst_lookup() (is Re: [PATCH][IPv6] separation xfrm_lookup from ip6_dst_lookup), Brian Haley |
| Previous by Thread: | Known problems with TCP window size on 2.6.7?, Petr Vandrovec |
| Next by Thread: | Re: [PATCH][ATM]: don't leak skb on as_indicate failure; don't wakeup twice on as_close, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |