| To: | Dan Williams <dcbw@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2.6.10-rc1 3/15] wireless/orinoco: encapsulate direct hardware operations |
| From: | David Gibson <hermes@xxxxxxxxxxxxxxxxxxxxx> |
| Date: | Wed, 27 Oct 2004 13:15:16 +1000 |
| Cc: | netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxxx |
| In-reply-to: | <1098816189.3663.47.camel@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <1098814320.3663.24.camel@xxxxxxxxxxxxxxxxxxxxxx> <1098816189.3663.47.camel@xxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040907i |
On Tue, Oct 26, 2004 at 02:43:09PM -0400, Dan Williams wrote:
> Update in-kernel orinoco wireless drivers to upstream CVS.
> None of this is original code by Dan Williams, simply a
> broken down patch set split-out from upstream orinoco CVS.
>
> o Encapsulate direct hardware operations so those symbols
> don't need to be exported
No! Don't apply this. This abstraction is only needed for the
orinoco_usb driver (so is in HEAD, but not the for_linus branch), but
IMO the abstraction is in the wrong place, and should not go
upstream. Of course, patches to make the abstraction not suck are
welcome.
--
David Gibson | For every complex problem there is a
david AT gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
|
| Previous by Date: | Re: [PATCH 2.6.10-rc1 4/15] wireless/orinoco: Update orinoco changelog and module parameters, David Gibson |
|---|---|
| Next by Date: | Re: [PATCH 2.6.10-rc1 7/15] wireless/orinoco: Update card reset/init code and add card-specific data structures, David Gibson |
| Previous by Thread: | [PATCH 2.6.10-rc1 3/15] wireless/orinoco: encapsulate direct hardware operations, Dan Williams |
| Next by Thread: | [PATCH 2.6.10-rc1 4/15] wireless/orinoco: Update orinoco changelog and module parameters, Dan Williams |
| Indexes: | [Date] [Thread] [Top] [All Lists] |