Re: [PATCH] select appropriate skb size in tcp

netdev

Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used

To:	"David S. Miller" <davem@xxxxxxxxxxxxx>
Subject:	Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used
From:	Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date:	Wed, 27 Oct 2004 11:41:11 +1000
Cc:	jgarzik@xxxxxxxxx, thomas.spatzier@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to:	<20041026170344.262bb3ec.davem@xxxxxxxxxxxxx>
References:	<OF96546AB5.ACE12043-ONC1256F33.0027BC6B-C1256F33.002D4A6E@xxxxxxxxxx> <E1CKE5P-0005SP-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20041020163510.6d13e9c7.davem@xxxxxxxxxxxxx> <20041026111912.GA18095@xxxxxxxxxxxxxxxxxxx> <20041026235126.GA4733@xxxxxxxxxxxxxxxxxxx> <417EE3BB.6040902@xxxxxxxxx> <20041027000724.GA4869@xxxxxxxxxxxxxxxxxxx> <20041026170344.262bb3ec.davem@xxxxxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.5.6+20040722i

On Tue, Oct 26, 2004 at 05:03:44PM -0700, David S. Miller wrote:
>
> Yes and no.  SG support requires TX csum support.  See the tests we
> make at register_netdev() time.
> 
> So as long as you enforce that rule, which I believe you are,
> things are fine.

That's right, the patch will turn off SG whenever TX csum is turned off.
And if you try to turn SG on while TX csum is off, it'll return EINVAL.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used, Herbert Xu Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used, Herbert Xu Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used, Jeff Garzik Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used, Herbert Xu Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used, David S. Miller Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used, Herbert Xu <= Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used, Jeff Garzik Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used, Herbert Xu Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used, David S. Miller Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used, Jeff Garzik

Previous by Date:	Re: [PATCH] 802.1Q VLAN, David S. Miller
Next by Date:	Re: [PATCHES] wireless: Update in-kernel orinoco driver, David Gibson
Previous by Thread:	Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used, David S. Miller
Next by Thread:	Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used, Jeff Garzik
Indexes:	[Date] [Thread] [Top] [All Lists]