Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Tue, Oct 26, 2004 at 08:15:31PM -0400, Jeff Garzik wrote:
>
> > IMHO it is valid to disable SG without disabling checksums, no?
> 
> It's useless:  The packet header is always in a separate memory
> location from the packet data, when using zerocopy sendfile(2).
> 
> When not using zerocopy sendfile, you are copying the data _anyway_.

I'm fine with adding this check.  However I think that belongs in
another patch since we don't check that in register_netdev currently.

Dave, what do you think?
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt