netdev
[Top] [All Lists]

Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 27 Oct 2004 10:22:09 +1000
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, thomas.spatzier@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041027001531.GA29973@xxxxxxxxxxxxx>
References: <OF96546AB5.ACE12043-ONC1256F33.0027BC6B-C1256F33.002D4A6E@xxxxxxxxxx> <E1CKE5P-0005SP-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20041020163510.6d13e9c7.davem@xxxxxxxxxxxxx> <20041026111912.GA18095@xxxxxxxxxxxxxxxxxxx> <20041026235126.GA4733@xxxxxxxxxxxxxxxxxxx> <417EE3BB.6040902@xxxxxxxxx> <20041027000724.GA4869@xxxxxxxxxxxxxxxxxxx> <20041027001531.GA29973@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Tue, Oct 26, 2004 at 08:15:31PM -0400, Jeff Garzik wrote:
>
> > IMHO it is valid to disable SG without disabling checksums, no?
> 
> It's useless:  The packet header is always in a separate memory
> location from the packet data, when using zerocopy sendfile(2).
> 
> When not using zerocopy sendfile, you are copying the data _anyway_.

I'm fine with adding this check.  However I think that belongs in
another patch since we don't check that in register_netdev currently.

Dave, what do you think?
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>