netdev
[Top] [All Lists]

Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Tue, 26 Oct 2004 19:54:35 -0400
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, thomas.spatzier@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041026235126.GA4733@xxxxxxxxxxxxxxxxxxx>
References: <OF96546AB5.ACE12043-ONC1256F33.0027BC6B-C1256F33.002D4A6E@xxxxxxxxxx> <E1CKE5P-0005SP-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20041020163510.6d13e9c7.davem@xxxxxxxxxxxxx> <20041026111912.GA18095@xxxxxxxxxxxxxxxxxxx> <20041026235126.GA4733@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
Herbert Xu wrote:
+static int __ethtool_set_sg(struct net_device *dev, u32 data)
+{
+       int err;
+
+       if (!data && dev->ethtool_ops->set_tso) {
+               err = dev->ethtool_ops->set_tso(dev, 0);
+               if (err)
+                       return err;
+       }
+
+       return dev->ethtool_ops->set_sg(dev, data);
+}

you want to disable tx-csum also


<Prev in Thread] Current Thread [Next in Thread>