netdev
[Top] [All Lists]

Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 27 Oct 2004 09:51:26 +1000
Cc: thomas.spatzier@xxxxxxxxxx, netdev@xxxxxxxxxxx, Jeff Garzik <jgarzik@xxxxxxxxx>
In-reply-to: <20041026111912.GA18095@xxxxxxxxxxxxxxxxxxx>
References: <OF96546AB5.ACE12043-ONC1256F33.0027BC6B-C1256F33.002D4A6E@xxxxxxxxxx> <E1CKE5P-0005SP-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20041020163510.6d13e9c7.davem@xxxxxxxxxxxxx> <20041026111912.GA18095@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Tue, Oct 26, 2004 at 09:19:12PM +1000, herbert wrote:
> On Wed, Oct 20, 2004 at 04:35:10PM -0700, David S. Miller wrote:
> > 
> > BTW, we allow mucking of all of these SG, TSO, CSUM settings
> > via ethtool yet the "X needs Y" rules are not enforced.  I
> > can't think of an easy way to do this without touching a lot
> > of drivers.  Perhaps something like:
> 
> Well since they're all being invoked through ethtool, you can
> just enforce the policy there.  So let's take set_tx_csum

Alright, here is a patch to do exactly that.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>