netdev
[Top] [All Lists]

Re: 2.6.9-mm1: pc_debug multiple definitions

To: Adrian Bunk <bunk@xxxxxxxxx>
Subject: Re: 2.6.9-mm1: pc_debug multiple definitions
From: Russell King <rmk+lkml@xxxxxxxxxxxxxxxx>
Date: Sat, 23 Oct 2004 00:07:55 +0100
Cc: Andrew Morton <akpm@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, jgarzik@xxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, prism54-private@xxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041022133929.GA2831@xxxxxxxxx>; from bunk@xxxxxxxxx on Fri, Oct 22, 2004 at 03:39:29PM +0200
Mail-followup-to: Adrian Bunk <bunk@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, jgarzik@xxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, prism54-private@xxxxxxxxxxx, netdev@xxxxxxxxxxx
References: <20041022032039.730eb226.akpm@xxxxxxxx> <20041022133929.GA2831@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5.1i
On Fri, Oct 22, 2004 at 03:39:29PM +0200, Adrian Bunk wrote:
> 
> The following compile error comes from Linus' tree:
> 
> 
> <--  snip  -->
> 
> ...
>   LD      drivers/built-in.o
> drivers/pcmcia/built-in.o(.bss+0xf20): multiple definition of `pc_debug'
> drivers/net/built-in.o(.data+0x24ae0): first defined here
> make[1]: *** [drivers/built-in.o] Error 1
> 
> <--  snip  -->
> 
> 
> The pc_debug in drivers/pcmcia/ds.c was made non-static in Linus' tree,
> but the global definition of a global variable with such a generic name 
> in drivers/net/wireless/prism54/islpci_mgt.c seems to be equally wrong.

I've forwarded it to Dominik to sort out with suggested solutions.
Hopefully Dominik will forward a fix soon.

(PS, I dropped David Hinds from the CC list - David doesn't maintain
2.6 PCMCIA.)

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

<Prev in Thread] Current Thread [Next in Thread>