Re: [patch netdev-2.6 0/2] r8169: vlan hwaccel fixes

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

John W. Linville <linville@xxxxxxxxxxxxx> :
[...]
> Patch 1:
> 
> The return value of rtl8169_tx_vlan_tag() is not being
> endian-swapped to little endian.  The hardware registers are little
> endian, even though the vlan tag value in this register (16-bits only)
> is big endian -- confusing!  Anyway, I'll be posting a follow-up patch
> to correct this.

Oops.

> Patch 2:
[nice explanation]

Any objection against me replacing the actual comment of patch #2 (i.e.
"why" instead of "how") and splitting the "if ((tp->>vlgrp = grp))" over
two lines ?

--
Ueimor