[PATCH] use mmiowb in tg3.c

netdev

[PATCH] use mmiowb in tg3.c

To:	akpm@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Subject:	[PATCH] use mmiowb in tg3.c
From:	Jesse Barnes <jbarnes@xxxxxxxxxxxx>
Date:	Thu, 21 Oct 2004 16:28:06 -0700
Cc:	netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx, davem@xxxxxxxxxxxxx, gnb@xxxxxxx, akepner@xxxxxxx
In-reply-to:	<200410211613.19601.jbarnes@xxxxxxxxxxxx>
References:	<200410211613.19601.jbarnes@xxxxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	KMail/1.7

This patch originally from Greg Banks.  Some parts of the tg3 driver depend on 
PIO writes arriving in order.  This patch ensures that in two key places 
using the new mmiowb macro.  This not only prevents bugs (the queues can be 
corrupted), but is much faster than ensuring ordering using PIO reads (which 
involve a few round trips to the target bus on some platforms).

Arthur has another patch that uses mmiowb in tg3 that he posted earlier as 
well.

Signed-off-by: Greg Banks <gnb@xxxxxxx>
Signed-off-by: Jesse Barnes <jbarnes@xxxxxxx

Thanks,
Jesse

tg3-mmiowb-2.patch
Description: Text document

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] use mmiowb in tg3.c, Jesse Barnes <= Re: [PATCH] use mmiowb in tg3.c, David S. Miller Re: [PATCH] use mmiowb in tg3.c, Benjamin Herrenschmidt Re: [PATCH] use mmiowb in tg3.c, akepner Re: [PATCH] use mmiowb in tg3.c, Benjamin Herrenschmidt Re: [PATCH] use mmiowb in tg3.c, Jesse Barnes Re: [PATCH] use mmiowb in tg3.c, Paul Mackerras [PATCH] use mmiowb in tg3_poll, akepner

Previous by Date:	Re: TCP-MD5 support, Andre Tomt
Next by Date:	Re: [PATCH] use mmiowb in tg3.c, David S. Miller
Previous by Thread:	[PATCH] replace dst_release refcount error with standard WARN_ON, Stephen Hemminger
Next by Thread:	Re: [PATCH] use mmiowb in tg3.c, David S. Miller
Indexes:	[Date] [Thread] [Top] [All Lists]