| To: | Rusty Russell <rusty@xxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Change masquerade code to use first IP address of interface. |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Wed, 20 Oct 2004 22:29:38 -0700 |
| Cc: | herbert@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxxxxxx, hno@xxxxxxxxxxxxxxx |
| In-reply-to: | <1098319849.10571.155.camel@xxxxxxxxxxxxxxxxxxxxx> |
| References: | <E1CKBtq-0005FC-00@xxxxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.61.0410201123200.25590@xxxxxxxxxxxxxxxxxxxxx> <20041020104650.GA20868@xxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.61.0410201300580.28452@xxxxxxxxxxxxxxxxxxxxx> <20041020111245.GA22703@xxxxxxxxxxxxxxxxxxx> <1098319849.10571.155.camel@xxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Thu, 21 Oct 2004 10:50:49 +1000 Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote: > On Wed, 2004-10-20 at 21:12, Herbert Xu wrote: > > On Wed, Oct 20, 2004 at 01:04:51PM +0200, Henrik Nordstrom wrote: > > > On Wed, 20 Oct 2004, Herbert Xu wrote: > > > > > > >I mean > > > > > > > > rt = (struct rtable *)(*pskb)->dst; > > > > newsrc = inet_select_addr(out, rt->rt_gateway, RT_SCOPE_UNIVERSE); > > > > > > IIRC we are not allowed to access this here, but I may be wrong.. If we > > > > Why? POST_ROUTING is called in three places in ip_output.c and they all > > give a valid dst. In fact ip_refrag in ip_conntrack_standalone.c is also > > accessing skb->dst. > > Yeah, I like it. Please send patch on top of mine to Dave, and we'll > see what blows up. Patrick feel free to send this along to me whenever you like. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Add appletalk 32bit ioctl emulation, David S. Miller |
|---|---|
| Next by Date: | Re: [PATCH 2.6] iptables CONNMARK match+target, Henrik Nordstrom |
| Previous by Thread: | Re: [PATCH] Change masquerade code to use first IP address of interface., Rusty Russell |
| Next by Thread: | Re: [PATCH] Change masquerade code to use first IP address of interface., Patrick McHardy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |