netdev
[Top] [All Lists]

Re: [RFC] Yield in netlink_broadcast when congested

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [RFC] Yield in netlink_broadcast when congested
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 19 Oct 2004 22:28:07 -0700
Cc: pablo@xxxxxxxxxxx, hadi@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041016113006.GA12843@xxxxxxxxxxxxxxxxxxx>
References: <20041016113006.GA12843@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 16 Oct 2004 21:30:06 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> So here is my proposal: if we detect signs of impending congestion
> in netlink_broadcast(), and that we're in a sleepable context, then
> we yield().
> 
> This gives the receivers a chance to pull down the messages without
> having the sender spinning indefinitely.  I've tested it on my UP
> machine and it does resolve the problem for ip monitor.
> 
> Comments anyone?

This looks great, patch applied.

Thanks Herbert.

<Prev in Thread] Current Thread [Next in Thread>