netdev
[Top] [All Lists]

Re: tun.c patch to fix "smp_processor_id() in preemptible code"

To: Lee Revell <rlrevell@xxxxxxxxxxx>
Subject: Re: tun.c patch to fix "smp_processor_id() in preemptible code"
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 19 Oct 2004 17:44:32 -0700
Cc: herbert@xxxxxxxxxxxxxxxxxxx, vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, maxk@xxxxxxxxxxxx, irda-users@xxxxxxxxxxxxxxxxxxxxx
In-reply-to: <1098226288.23628.6.camel@xxxxxxxxxxxxxxxx>
References: <E1CK1e6-0004F3-00@xxxxxxxxxxxxxxxxxxxxxxxx> <1098222676.23367.18.camel@xxxxxxxxxxxxxxxx> <20041019215401.GA16427@xxxxxxxxxxxxxxxxxxx> <1098223857.23367.35.camel@xxxxxxxxxxxxxxxx> <20041019153308.488d34c1.davem@xxxxxxxxxxxxx> <1098225729.23628.2.camel@xxxxxxxxxxxxxxxx> <20041019154249.6afcaaad.davem@xxxxxxxxxxxxx> <1098226288.23628.6.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 19 Oct 2004 18:51:28 -0400
Lee Revell <rlrevell@xxxxxxxxxxx> wrote:

> OK, thanks for clarifying.  The correct patch is therefore:
 ...
>  static inline int netif_rx_ni(struct sk_buff *skb)
>  {
> +       preempt_disable();
>         int err = netif_rx(skb);

You need to put statements after local function variable
declarations.

<Prev in Thread] Current Thread [Next in Thread>