| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2.6]: Fix policy update bug when increasing priority of last policy |
| From: | Patrick McHardy <kaber@xxxxxxxxx> |
| Date: | Tue, 19 Oct 2004 16:24:12 +0200 |
| Cc: | davem@xxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <E1CJhER-0001vk-00@xxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <E1CJhER-0001vk-00@xxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5 |
Herbert Xu wrote: Patrick McHardy <kaber@xxxxxxxxx> wrote:This patch checks for *p != NULL before continuing the loop.Unfortunately that doesn't fix it completely. The real bug is the fact that we continue with a bogus p pointing to the deleted element. So what we should do is continue without updating p at all. You're right, your patch is better. I've tested it and it works fine. Regards Patrick |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [XFRM] Allow transport SAs even when there is no policy, Patrick McHardy |
|---|---|
| Next by Date: | Re: [PATCH 2.6.9-rc4-bk3-netdev3 1/3] r8169: always clean Tx desc, Jeff Garzik |
| Previous by Thread: | Re: [PATCH 2.6]: Fix policy update bug when increasing priority of last policy, Herbert Xu |
| Next by Thread: | Re: [PATCH 2.6]: Fix policy update bug when increasing priority of last policy, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |