netdev
[Top] [All Lists]

Re: [PATCH 2.4.28-pre4-bk3] forcedeth: Gigabit ethernet support and medi

To: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 2.4.28-pre4-bk3] forcedeth: Gigabit ethernet support and media detection changes
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Sun, 17 Oct 2004 09:46:31 -0400
Cc: marcelo.tosatti@xxxxxxxxxxxx, blazara@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.44.0410171216490.29815-100000@xxxxxxxxxxx>
References: <Pine.LNX.4.44.0410171216490.29815-100000@xxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
Manfred Spraul wrote:
Backport of the 0.29 forcedeth driver to 2.4.
Changes:
- lots of bugfixes.
- completely rewritten PHY initialization and media detection
- gigabit ethernet support

The actual backport was done by Jane Liu from NVIDIA:

- all occurrences of msleep changed to mdelay

NAK, mdelay(500) isn't acceptable. Use schedule_timeout or add msleep to 2.4.x.


- SET_NETDEV_DEV calls removed

NAK, SET_NETDEV_DEV() exists in 2.4.x


- module_param call changed to MODULE_PARM

OK

        Jeff


<Prev in Thread] Current Thread [Next in Thread>