netdev
[Top] [All Lists]

[PATCH] skfp: remove assignment expression in conditional (sparse)(v2)

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: [PATCH] skfp: remove assignment expression in conditional (sparse)(v2)
From: "Randy.Dunlap" <rddunlap@xxxxxxxx>
Date: Fri, 15 Oct 2004 14:50:46 -0700
Cc: netdev <netdev@xxxxxxxxxxx>, mlindner@xxxxxxxxxxxxx
In-reply-to: <41702405.6070100@xxxxxxxxx>
Organization: OSDL
References: <4169BB68.7030206@xxxxxxxx> <41702405.6070100@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 0.8 (X11/20040913)
I would prefer to fix a 'assignment expression in conditional' warning by splitting the assignment and the test.

    Jeff

OK, here you are.

--
~Randy
Fix sparse warning:
drivers/net/skfp/hwmtm.c:1904:20: warning: assignment expression in conditional

Signed-off-by: Randy Dunlap <rddunlap@xxxxxxxx>


diffstat:=
 drivers/net/skfp/hwmtm.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -Naurp ./drivers/net/skfp/hwmtm.c~skfp_expr ./drivers/net/skfp/hwmtm.c
--- ./drivers/net/skfp/hwmtm.c~skfp_expr        2004-08-13 22:36:59.000000000 
-0700
+++ ./drivers/net/skfp/hwmtm.c  2004-10-15 14:47:41.942720928 -0700
@@ -1901,7 +1901,8 @@ void smt_send_mbuf(struct s_smc *smc, SM
        }
 
        if (!smc->hw.mac_ring_is_up || frag_count > queue->tx_free) {
-               if (frame_status &= ~LAN_TX) {
+               frame_status &= ~LAN_TX;
+               if (frame_status) {
                        DB_TX("Ring is down: terminate LAN_TX",0,0,2) ;
                }
                else {
<Prev in Thread] Current Thread [Next in Thread>