| To: | "Christian Borntraeger" <linux-kernel@xxxxxxxxxxxxxxx> |
|---|---|
| Subject: | RE: [Patch 12/16 2.5] ixgb: replace kmalloc with vmalloc to allocate driver local data structures |
| From: | "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx> |
| Date: | Fri, 15 Oct 2004 13:10:03 -0700 |
| Cc: | <jgarzik@xxxxxxxxx>, "netdev" <netdev@xxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| Thread-index: | AcSy1phBTlkAa6RRSuy/l0mQHNlhTwAHAgPg |
| Thread-topic: | [Patch 12/16 2.5] ixgb: replace kmalloc with vmalloc to allocate driver local data structures |
Kmalloc resources are more scarce than vmalloc. In this case, there are systems where allocation of [rt]xdr->buffer_info fails when the descriptor ring sizes are set to the maximum allowable value (4096) and kmalloc is used. Using vmalloc solves this issue. Ganesh. -----Original Message----- From: Christian Borntraeger [mailto:linux-kernel@xxxxxxxxxxxxxxx] Sent: Friday, October 15, 2004 9:47 AM To: Venkatesan, Ganesh Cc: jgarzik@xxxxxxxxx; netdev Subject: Re: [Patch 12/16 2.5] ixgb: replace kmalloc with vmalloc to allocate driver local data structures Ganesh Venkatesan wrote: > - rxdr->buffer_info = kmalloc(size, GFP_KERNEL); [...] > + rxdr->buffer_info = vmalloc(size); What is the rationale for this change? If I recall correctly, Linus opposes the use of vmalloc if there is no real need. cheers Christian |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2.6.9-rc2 8/8] S2io: two buffer mode, Andi Kleen |
|---|---|
| Next by Date: | Re: mm kernel oops with r8169 & named, PREEMPT, Danny |
| Previous by Thread: | Re: [Patch 12/16 2.5] ixgb: replace kmalloc with vmalloc to allocate driver local data structures, Christian Borntraeger |
| Next by Thread: | [Patch 14/16 2.5] ixgb: version number update, Ganesh Venkatesan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |