Re: PATCH: netpoll with xircom

netdev

Re: PATCH: netpoll with xircom_cb

To:	Matt Mackall <mpm@xxxxxxxxxxx>
Subject:	Re: PATCH: netpoll with xircom_cb
From:	Jeff Garzik <jgarzik@xxxxxxxxx>
Date:	Thu, 14 Oct 2004 23:25:33 -0400
Cc:	Petr Konecny <pekon@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to:	<20041014205440.GY5414@xxxxxxxxx>
References:	<qww8yaarph5.fsf@xxxxxxxxxxxxxxxxxx> <20041014205440.GY5414@xxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922

Matt Mackall wrote:

On Thu, Oct 14, 2004 at 04:41:10AM +0200, Petr Konecny wrote:

Hi,

I have a headless computer with xircom pcmcia card and needed netconsole
on it. After looking around in other drivers I concocted this patch.  It
survived light testing. I have no documentation for the hw, so it maybe
totally bogus. What do you think ?



Looks good to me.

In general, this generic approach is fine. We can sometimes avoid the
heavyweight IRQ manipulation by using internal driver locking, but

this is generally not a performance-critical path.

Jeff, did you take this one?

yes

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
PATCH: netpoll with xircom_cb, Petr Konecny Re: PATCH: netpoll with xircom_cb, Matt Mackall Re: PATCH: netpoll with xircom_cb, Jeff Garzik <= Re: PATCH: netpoll with xircom_cb, Petr Konecny

Previous by Date:	[PATCH] remove unused memcpy_tokerneliovec, Andrew Grover
Next by Date:	Re: 2.6.9-rc4 tcp_transmit_skb: BUG_ON(!tcp_skb_pcount(skb)), Herbert Xu
Previous by Thread:	Re: PATCH: netpoll with xircom_cb, Matt Mackall
Next by Thread:	Re: PATCH: netpoll with xircom_cb, Petr Konecny
Indexes:	[Date] [Thread] [Top] [All Lists]