netdev
[Top] [All Lists]

Re: PATCH: netpoll with xircom_cb

To: Petr Konecny <pekon@xxxxxxxxxx>
Subject: Re: PATCH: netpoll with xircom_cb
From: Matt Mackall <mpm@xxxxxxxxxxx>
Date: Thu, 14 Oct 2004 15:54:40 -0500
Cc: netdev@xxxxxxxxxxx, Jeff Garzik <jgarzik@xxxxxxxxx>
In-reply-to: <qww8yaarph5.fsf@xxxxxxxxxxxxxxxxxx>
References: <qww8yaarph5.fsf@xxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Thu, Oct 14, 2004 at 04:41:10AM +0200, Petr Konecny wrote:
> Hi,
> 
> I have a headless computer with xircom pcmcia card and needed netconsole
> on it. After looking around in other drivers I concocted this patch.  It
> survived light testing. I have no documentation for the hw, so it maybe
> totally bogus. What do you think ?

Looks good to me.

In general, this generic approach is fine. We can sometimes avoid the
heavyweight IRQ manipulation by using internal driver locking, but
this is generally not a performance-critical path. 

Jeff, did you take this one?

-- 
Mathematics is the supreme nostalgia of our time.


<Prev in Thread] Current Thread [Next in Thread>