[Top] [All Lists]

Re: [PATCH 2.6.9-rc2 7/8] S2io: NAPI fix

To: ravinandan.arakali@xxxxxxxx
Subject: Re: [PATCH 2.6.9-rc2 7/8] S2io: NAPI fix
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Thu, 14 Oct 2004 11:00:27 -0400
Cc: "'Francois Romieu'" <romieu@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, leonid.grossman@xxxxxxxx, raghavendra.koushik@xxxxxxxx, rapuru.sriram@xxxxxxxx
In-reply-to: <005601c4b18b$691ac8b0$6c10100a@xxxxxxxxxxxx>
References: <005601c4b18b$691ac8b0$6c10100a@xxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
Comments on patch #7:

1) Can you prove that put_lock is really necessary, and not covered by other methods of synchronization? Typically the preferred model is that your RX process requires _no_ spinlocks, and instead you use the net stack API to ensure when your RX process is, and is not, running.

otherwise, no objections to this patch

<Prev in Thread] Current Thread [Next in Thread>