netdev
[Top] [All Lists]

Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h

To: Jan Dittmer <j.dittmer@xxxxxxxxxxx>
Subject: Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h
From: Cal Peake <cp@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 11 Oct 2004 08:23:35 -0400 (EDT)
Cc: Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, NetDev Mailing List <netdev@xxxxxxxxxxx>, proski@xxxxxxx, hermes@xxxxxxxxxxxxxxxxxxxxx
In-reply-to: <416A7484.1030703@xxxxxxxxxxx>
References: <Pine.LNX.4.61.0410110702590.7899@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <416A7484.1030703@xxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 11 Oct 2004, Jan Dittmer wrote:

> Cal Peake wrote:
> 
> >     inw((hw)->iobase + ( (off) << (hw)->reg_spacing )) : \
> > -   readw((hw)->iobase + ( (off) << (hw)->reg_spacing )))
> > +   readw((void __iomem *)(hw)->iobase + ( (off) << (hw)->reg_spacing )))
> >  #define hermes_write_reg(hw, off, val) do { \
> 
> Isn't the correct fix to declare iobase as (void __iomem *) ?

iobase is an unsigned long, declaring it as a void pointer is prolly not 
what we want to do here. The typecast seems proper. A lot of other drivers 
do this as well thus it must be proper ;-)

-- Cal


<Prev in Thread] Current Thread [Next in Thread>