netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH 2/2] [SKBUFF] introduce tr_hdr(skb)

from [Arnaldo Carvalho de Melo] [Permanent Link][Original]
To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH 2/2] [SKBUFF] introduce tr_hdr(skb)
From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Date: Wed, 06 Oct 2004 16:06:54 -0300
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20041006185835.GB19714@xxxxxxxxxxxxxx>
Organization: Conectiva S.A.
References: <41643C40.8070605@xxxxxxxxxxxxxxxx> <20041006185835.GB19714@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 0.8 (X11/20040913) 


Thomas Graf wrote:

* Arnaldo Carvalho de Melo <41643C40.8070605@xxxxxxxxxxxxxxxx> 2004-10-06 15:41


-               trh = (struct trh_hdr *)skb_push(skb, sizeof(*trh));
+               skb->mac.raw = skb_push(skb, sizeof(*trh));
+               trh = tr_hdr(skb);
                trh->ac = AC;
                trh->fc = LLC_FRAME;
                if (sa)
@@ -51,7 +52,6 @@
                        memcpy(trh->daddr, da, dev->addr_len);
                        tr_source_route(skb, trh, dev);
                }
-               skb->mac.raw = skb->data;



Are you sure the bevhaviour is the same? There is an skb_pull
in tr_source_route so skb->data gets modified. 




Thanks for reviewing, checking...
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH 2/2] [SKBUFF] introduce tr_hdr(skb), Thomas Graf
Next by Date:  Re: [RFC] using mmiowb() in dev->poll() method, David S. Miller
Previous by Thread:  Re: [PATCH 2/2] [SKBUFF] introduce tr_hdr(skb), Thomas Graf
Next by Thread:  Re: [PATCH 2/2] [SKBUFF] introduce tr_hdr(skb), Arnaldo Carvalho de Melo
Indexes:  [Date] [Thread] [Top] [All Lists]