netdev
[Top] [All Lists]

Re: [TCP] Show all SYN_RECV sockets in /proc/net/tcp

To: acme@xxxxxxxxxxxxxxxx
Subject: Re: [TCP] Show all SYN_RECV sockets in /proc/net/tcp
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Wed, 06 Oct 2004 11:55:17 +0900 (JST)
Cc: herbert@xxxxxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <416355BD.50402@xxxxxxxxxxxxxxxx>
Organization: USAGI Project
References: <20041006020650.GA14583@xxxxxxxxxxxxxxxxxxx> <416355BD.50402@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article <416355BD.50402@xxxxxxxxxxxxxxxx> (at Tue, 05 Oct 2004 23:17:33 
-0300), Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx> says:

> > I found that /proc/net/tcp didn't do it correctly either.  So here is
> > a small patch to fix /proc/net/tcp.
> > 
> > The logic in there stinks though so I'd love to see a rewrite.
> 
> Go ahead and do it with the current seq_file infrastructure 8) Standard
> answer for these cases is remove /proc/net/tcp altogether and convert
> the userland tools to use netlink instead.

It is okay to have dual interface (procfs and netlink), but
please, please do not remove /proc/net/tcp (during 2.6.x at least).
And, yes, if you want to add something, it should be done in netlink.

Thanks.

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>