Re: PATCH: [SKBUFF] introduce skb_link_header_size(skb)

[Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>]

Thomas Graf wrote:
> * Arnaldo Carvalho de Melo <4162F28B.2050308@xxxxxxxxxxxxxxxx> 2004-10-05 16:14
>
> > +static inline int skb_link_header_size(const struct sk_buff *skb)
> > +{
> > +       return skb->nh.raw - skb->mac.raw;
> > +}
>
> The patch is valid and I think it is right to do so but this may lead to
> wrong results when skb->mac.raw is set to 0x0 F.e in classifiers. Maybe
> add a comment to warn about it?
I never looked at classifiers code, suggest a comment and I'll stick it
there.

Thanks for commenting on the patch.

Regards,

- Arnaldo