netdev
[Top] [All Lists]

Re: Race between neigh_timer_handler and neigh_event_send

To: Greg Banks <gnb@xxxxxxx>
Subject: Re: Race between neigh_timer_handler and neigh_event_send
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 5 Oct 2004 11:57:25 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20041005101532.GA935@xxxxxxx>
References: <20041005101532.GA935@xxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Good catch Greg.

All of this trouble is because this is the one spot where we
make reference to the arp_queue packets without neigh->lock
held.

I wish we could avoiding dropping the lock instead, but that
is not the case.  All of these ->solicit() methods can end
up calling back down into the neighbour layer and try to grab
the lock again.

I'll apply your patch, thanks.

<Prev in Thread] Current Thread [Next in Thread>