netdev
[Top] [All Lists]

[PATCH 2.6 7/7]: Missing rtnl_unlock in register_vlan_device error path

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: [PATCH 2.6 7/7]: Missing rtnl_unlock in register_vlan_device error path
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Sun, 03 Oct 2004 23:13:44 +0200
Cc: netdev@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5
rtnl_unlock is not called in the out_free_unregister error path.


# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/10/03 20:44:53+02:00 kaber@xxxxxxxxxxxx 
#   [VLAN]: Missing rtnl_unlock in register_vlan_device error path
#   
#   Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
# 
# net/8021q/vlan.c
#   2004/10/03 20:44:27+02:00 kaber@xxxxxxxxxxxx +1 -1
#   [VLAN]: Missing rtnl_unlock in register_vlan_device error path
#   
#   Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
# 
diff -Nru a/net/8021q/vlan.c b/net/8021q/vlan.c
--- a/net/8021q/vlan.c  2004-10-03 22:21:30 +02:00
+++ b/net/8021q/vlan.c  2004-10-03 22:21:30 +02:00
@@ -537,7 +537,7 @@
 
 out_free_unregister:
        unregister_netdev(new_dev);
-       goto out_put_dev;
+       goto out_unlock;
 
 out_free_newdev:
        free_netdev(new_dev);
<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 2.6 7/7]: Missing rtnl_unlock in register_vlan_device error path, Patrick McHardy <=