netdev
[Top] [All Lists]

[PATCH 2.6 5/7]: Fix ipip_fb_tunnel_dev leak in ipip_fini

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: [PATCH 2.6 5/7]: Fix ipip_fb_tunnel_dev leak in ipip_fini
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Sun, 03 Oct 2004 23:13:19 +0200
Cc: netdev@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5
ipip_fb_tunnel_dev doesn't have a destructor set
and is not freed manually. Set the destructor in
ipip_tunnel_setup to fix the leak.


# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/10/03 20:42:17+02:00 kaber@xxxxxxxxxxxx 
#   [IPV4]: Fix ipip_fb_tunnel_dev leak in ipip_fini
#   
#   Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
# 
# net/ipv4/ipip.c
#   2004/10/03 20:41:38+02:00 kaber@xxxxxxxxxxxx +1 -1
#   [IPV4]: Fix ipip_fb_tunnel_dev leak in ipip_fini
#   
#   Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
# 
diff -Nru a/net/ipv4/ipip.c b/net/ipv4/ipip.c
--- a/net/ipv4/ipip.c   2004-10-03 22:20:49 +02:00
+++ b/net/ipv4/ipip.c   2004-10-03 22:20:49 +02:00
@@ -246,7 +246,6 @@
        nt = dev->priv;
        SET_MODULE_OWNER(dev);
        dev->init = ipip_tunnel_init;
-       dev->destructor = free_netdev;
        nt->parms = *parms;
 
        if (register_netdevice(dev) < 0) {
@@ -784,6 +783,7 @@
        dev->get_stats          = ipip_tunnel_get_stats;
        dev->do_ioctl           = ipip_tunnel_ioctl;
        dev->change_mtu         = ipip_tunnel_change_mtu;
+       dev->destructor         = free_netdev;
 
        dev->type               = ARPHRD_TUNNEL;
        dev->hard_header_len    = LL_MAX_HEADER + sizeof(struct iphdr);
<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 2.6 5/7]: Fix ipip_fb_tunnel_dev leak in ipip_fini, Patrick McHardy <=