Re: [PATCH] introduce eth_hdr(skb)

[Joe Perches <joe@xxxxxxxxxxx>]

On Sat, 2 Oct 2004, Arnaldo Carvalho de Melo wrote:
> Joe Perches wrote:
> > 
> > -       } else if (skb->mac.ethernet->h_proto == 
> > __constant_htons(ETH_P_ARP)) {
> > +       } else if (eth_hdr(skb)->h_proto == htons(ETH_P_ARP)) {
> > 
> > I believe the __constant_htons conversions to htons are incorrect.
> 
> No they aren't, look at the generated code for both variations when 
> receiving a constant :-)

Perhaps, but if you are going to change some, shouldn't you instead
change all the similar net/bridge uses in a different changset?