| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH]: fixed typo of reassembly.c |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Fri, 1 Oct 2004 23:38:32 -0700 |
| Cc: | yasuyuki.kozakai@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, usagi-core@xxxxxxxxxxxxxx |
| In-reply-to: | <E1CDc2I-0003wP-00@xxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20041001151923.261b42b3.davem@xxxxxxxxxxxxx> <E1CDc2I-0003wP-00@xxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sat, 02 Oct 2004 15:02:22 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> David S. Miller <davem@xxxxxxxxxxxxx> wrote:
> >
> > It is textual fix only, do you realize this?
> > Both ntohs() and htons() perform the same transformation
> > on a 16-bit data item. It really does not matter which
> > one you actually use, in practice.
>
> It might make a difference in future if the sparse people decide to
> annotate its arguments/return values.
That's true. Al Viro has done this on the filesystems
and "cpu_to_{be,le}{16,32,64}()" et al. interfaces.
I'm sure he'll hit the networking before long.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH]: fixed typo of reassembly.c, Herbert Xu |
|---|---|
| Next by Date: | Re: [6/6]: jenkins hash for neigh, Herbert Xu |
| Previous by Thread: | Re: [PATCH]: fixed typo of reassembly.c, Herbert Xu |
| Next by Thread: | Re: [PATCH] (1/3) tcp - choose congestion algorithm at initialization, Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |