netdev
[Top] [All Lists]

Re: generic 802.11 stack

To: Vladimir Kondratiev <vkondra@xxxxxxx>
Subject: Re: generic 802.11 stack
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 1 Oct 2004 17:11:58 -0700
Cc: netdev@xxxxxxxxxxx, mcgrof@xxxxxxxxxxxxxxxxxxxx, acx100-devel@xxxxxxxxxxxxxxxxxxxxx, prism54-devel@xxxxxxxxxxx
In-reply-to: <200410020125.40669.vkondra@xxxxxxx>
References: <200408312111.02438.vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <200410011630.59465.vkondra@xxxxxxx> <20041001155310.515ee09e.davem@xxxxxxxxxxxxx> <200410020125.40669.vkondra@xxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 2 Oct 2004 01:25:32 +0200
Vladimir Kondratiev <vkondra@xxxxxxx> wrote:

> DS> Next:
> DS>
> DS> +    dev->mtu                = 2304;
> DS> +    dev->type               = ARPHRD_IEEE80211;
> DS>
> DS> Is this really the correct default MTU for wireless devices?
> 
> Yes, 802.11e (QoS) defines this value.

All existing wireless drivers use the standard ethernet MTU.
I really think it is supposed to be 1500.

That's why I left it at ether_setup()'s setting.

Upper layers really want to see a 1500 byte standard ethernet
MTU by default.  It's OK to let people set this higher via
netdev->change_mtu() configuration calls, but by default it
should be something that makes sense for most networks and
that is 1500.

Yes, btw, your tabs are all screwed up.  Please configure
your editor to use real tab characters.  Your's is using
spaces and using a tab-stop of 4 when it should be 8.

<Prev in Thread] Current Thread [Next in Thread>