netdev
[Top] [All Lists]

Re: Advice needed on IP-over-InfiniBand driver

To: Roland Dreier <roland@xxxxxxxxxxx>
Subject: Re: Advice needed on IP-over-InfiniBand driver
From: David Stevens <dlstevens@xxxxxxxxxx>
Date: Thu, 30 Sep 2004 14:21:20 -0700
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, openib-general@xxxxxxxxxx
In-reply-to: <521xgj1tx8.fsf@xxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
> However, it seems that broadcast ARP packets have skb->dst == NULL.
> Is it safe for me to assume that packets with skb->dst == NULL are
> broadcast packets?  Will multicast packets have a non-NULL dst?

I think it would be a mistake to use skb->dst as a flag for unicast
or not. Even if it is correct in all cases you care about now (I don't
know either way), it would be a hidden dependency with high potential
to break something eventually.

                                                +-DLS


<Prev in Thread] Current Thread [Next in Thread>