Re: bad TSO performance in 2.6.9-rc2-BK

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Mon, Sep 27, 2004 at 09:59:01PM -0700, David S. Miller wrote:
> 
> It's got a nasty bug though, I'm not updating
> TCP_SKB_CB(skb)->seq so retransmits have corrupted
> sequence numbers, doh!  And hey if I update that
> then I do not need this tso_offset thingy.

Nice work.

> +     if (skb->len != (data_end_seq - data_seq)) {

Please make that > so that I can sleep at night :)

> +             if (__tcp_trim_head(sk, skb, data_end_seq - data_seq))

The argument to __tcp_trim_head should be

skb->len - (data_end_seq - data_seq)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt