netdev
[Top] [All Lists]

Re: [PATCH 2.6] natsemi.c NAPI

To: Robert Olsson <robert.olsson@xxxxxxxxxxx>
Subject: Re: [PATCH 2.6] natsemi.c NAPI
From: Eric Lemoine <eric.lemoine@xxxxxxxxx>
Date: Mon, 27 Sep 2004 19:30:21 +0200
Cc: Harald Welte <laforge@xxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <16727.60345.857450.162620@xxxxxxxxxxxx>
References: <20040919163642.GC1307@xxxxxxxxxxxxxxxxxxxxxxx> <4155D781.8050700@xxxxxxxxxxxxxxxx> <20040927091148.GF3236@xxxxxxxxxxxxxxxxxxxxxxx> <16727.60345.857450.162620@xxxxxxxxxxxx>
Reply-to: Eric Lemoine <eric.lemoine@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
>  > I think this overall problem can be solved if there was some per-device
>  > variable that saves the IntrStatus until the NAPI callback gets
>  > scheduled. What do you think?  This wouldn't even need some locking,
>  > since interrupts would be disabled before the field is updated, and not
>  > re-enabled before the field is read by the NAPI callback?
>  >
>  > I was surprised that this solution is not suggested in the NAPI-HOWTO.txt, 
> so I though there must be an error in my proposal...
>  >
>  > By using such a scheme, isn't it also possible to only offload RX into
>  > the NAPI callback with clear-on-read devices?
>  >
> 
>  e1000 used such technique before.If a remember correctly IntrStatus was
>  saved in device priv struct.

That's also how it is done in current sungem.

-- 
Eric

<Prev in Thread] Current Thread [Next in Thread>