Re: [5/6]: Dynamic neigh hash table growth

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

David S. Miller <davem@xxxxxxxxxxxxx> wrote:
>
> +static void neigh_hash_grow(struct neigh_table *tbl, unsigned long 
> new_entries)
> +{
> +       struct neighbour **new_hash, **old_hash;
> +       unsigned int i, new_hash_mask, old_entries;
> +
> +       BUG_ON(new_entries & (new_entries - 1));
> +       new_hash = neigh_hash_alloc(new_entries);

Perhaps it'd be better to bound it based on MAX_ORDER rather than waiting
for neigh_hash_alloc() to fail?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt