| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: bad TSO performance in 2.6.9-rc2-BK |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Mon, 27 Sep 2004 12:50:48 +1000 |
| Cc: | ak@xxxxxxx, niv@xxxxxxxxxx, andy.grover@xxxxxxxxx, anton@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <E1CBkIW-0001dF-00@xxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20040923164149.5368d291.davem@xxxxxxxxxxxxx> <E1CBkIW-0001dF-00@xxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040722i |
On Mon, Sep 27, 2004 at 11:27:24AM +1000, Herbert Xu wrote: > > Indeed, I think the new code means that Minshall's check will disable > Nagle which is what was keeping TSO working properly. > > Anton, could you please try this patch which disables Minshall's check > and see what it does? Never mind. Minshall is innocent :) We set the maximum TSO factor bounded by the congestion window. But when the congestion window is raised, we don't call tcp_sync_mss which is the only place that can raise the TSO factor. So the TSO factor never grows above what we start with. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| Previous by Date: | Re: bad TSO performance in 2.6.9-rc2-BK, Herbert Xu |
|---|---|
| Next by Date: | Re: recommendations for NIC HW(/SW) design?, David S. Miller |
| Previous by Thread: | Re: bad TSO performance in 2.6.9-rc2-BK, Herbert Xu |
| Next by Thread: | Re: bad TSO performance in 2.6.9-rc2-BK, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |