| To: | jesse.brandeburg@xxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH 1/2 2.6] e100: fix NAPI race with watchdog |
| From: | James Chapman <jchapman@xxxxxxxxxxx> |
| Date: | Thu, 23 Sep 2004 10:08:48 +0100 |
| Cc: | jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Internet Messaging Program (IMP) 3.2.2 |
> While polling in NAPI mode, we were occassionally getting interrupts > re-enabled by the watchdog trying to generate a software interrupt. > Fix is to add a spinlock around that shared hardware register to > allow a read-modify-write operation. This was nasty nasty. I don't > like the spinlock in the hot path but i see no other way. Comments > are welcome. While working with NAPI on the e100 a while ago, I seriously considered removing the generation of the sw interrupt altogether for the NAPI case. Does it serve any purpose? NAPI is polling the driver already anyway. /james |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [IPv4] Kill remnant of ip_nat_dumb, Harald Welte |
|---|---|
| Next by Date: | Re: 2.6.9-rc2-mm2 fn_hash_insert oops, Herbert Xu |
| Previous by Thread: | Re: [PATCH 1/2 2.6] e100: fix NAPI race with watchdog, Stephen Hemminger |
| Next by Thread: | [PATCH 2/2 2.6] e100: whitespace and DPRINTKS, Jesse Brandeburg |
| Indexes: | [Date] [Thread] [Top] [All Lists] |