netdev
[Top] [All Lists]

Re: [PATCH] Clean up fib_hash datastructures

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: [PATCH] Clean up fib_hash datastructures
From: Andi Kleen <ak@xxxxxxx>
Date: Tue, 21 Sep 2004 14:07:53 +0200
Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <1095764621.1049.14.camel@xxxxxxxxxxxxxxxx>
References: <20040918203319.24004d6e.davem@xxxxxxxxxxxxx> <1095645106.1048.190.camel@xxxxxxxxxxxxxxxx> <20040919195351.0b3560e6.davem@xxxxxxxxxxxxx> <1095686672.1049.301.camel@xxxxxxxxxxxxxxxx> <20040920121123.70baf895.davem@xxxxxxxxxxxxx> <20040921034212.GA28462@xxxxxxxxxxxxxxxxxxx> <20040920231805.3f18479c.davem@xxxxxxxxxxxxx> <20040921090423.GE8058@xxxxxxxxxxxxx> <20040921093252.GA32545@xxxxxxxxxxxxxxxxxxx> <1095764621.1049.14.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, Sep 21, 2004 at 07:03:41AM -0400, jamal wrote:
> On Tue, 2004-09-21 at 05:32, Herbert Xu wrote:
> 
> > If we were doing this from scratch then we should do that.  But as it
> > is we must keep the TOS code for compatibility.
> 
> Important for marketing to be able to claim _full_ RFC 1812 compliance.
> Kepp the TOS!
> I know it sounds silly, but there are a lot more foolish people out
> there addicted to glossyware.

I didn't know you were addicted to glossyware, jamal ;-)

You could still do routing by TOS, all you would need to do is to 
set up a netfilter rule that checks the TOS and set an fwmark, then
route based on that.

The only thing you lose is ICMP redirect routes per TOS.
I'm not sure it is worth keeping. And making the FIB scale
better would likely look far better in the glossyware than
that. 

-Andi

<Prev in Thread] Current Thread [Next in Thread>