| To: | Stephen Hemminger <shemminger@xxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] pktgen handle netdev device getting full. |
| From: | Ben Greear <greearb@xxxxxxxxxxxxxxx> |
| Date: | Thu, 16 Sep 2004 15:59:30 -0700 |
| Cc: | Robert Olsson <Robert.Olsson@xxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx, Jamal Hadi Salim <hadi@xxxxxxxx> |
| In-reply-to: | <20040916144332.37f19fcb@xxxxxxxxxxxxxxxxxxxxx> |
| Organization: | Candela Technologies |
| References: | <20040916144332.37f19fcb@xxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040913 |
Stephen Hemminger wrote: I was trying out pktgen on a NIC with an undersized ring, so hard_start_xmit would always return non-zero when full. This caused a slewof console messages. Better to just have pktgen retry in this case. My understanding is that if the queue is not stopped, then you should not get the hard xmit errors. So, in a proper driver, you should not see these printks. By the way, is there any interest in adding my patch that also allows pktgen to receive packets (and count the statistics, etc)? I know DaveM objected to the hook in the skb-receive logic some time back, but maybe he has a different opinion now? Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: The ultimate TOE design, Lincoln Dale |
|---|---|
| Next by Date: | Re: [PATCH] pktgen handle netdev device getting full., David S. Miller |
| Previous by Thread: | [PATCH] pktgen handle netdev device getting full., Stephen Hemminger |
| Next by Thread: | Re: [PATCH] pktgen handle netdev device getting full., David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |