netdev
[Top] [All Lists]

Re: [INET] Add flags field to ip_tunnel_parm

To: herbert@xxxxxxxxxxxxxxxxxxx
Subject: Re: [INET] Add flags field to ip_tunnel_parm
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Tue, 14 Sep 2004 21:52:05 +0900 (JST)
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <20040914121617.GA5652@xxxxxxxxxxxxxxxxxxx>
Organization: USAGI Project
References: <20040914121617.GA5652@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article <20040914121617.GA5652@xxxxxxxxxxxxxxxxxxx> (at Tue, 14 Sep 2004 
22:16:17 +1000), Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> says:

> BTW if anyone else wants to add more fields to the structure, now is
> the time.

Well, you simply cannot do this.

Kernel will get garbage from old binaries,
and kernel will break user space if it tries 
to get params into old structure.

So, please change SIOxxxTUNNEL values to support both interfaces
(or give up ioctl and use rtnetlink instead!)

Thanks.

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

<Prev in Thread] Current Thread [Next in Thread>