netdev
[Top] [All Lists]

Re: [PATCH 2.6] ip_nat_ftp - manip at the right place

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2.6] ip_nat_ftp - manip at the right place
From: Harald Welte <laforge@xxxxxxxxxxxxx>
Date: Tue, 14 Sep 2004 09:12:41 +0200
Cc: Julian Anastasov <ja@xxxxxx>, netdev@xxxxxxxxxxx, rusty@xxxxxxxxxxxxxxx
In-reply-to: <20040912170323.65eadc38.davem@xxxxxxxxxxxxx>
References: <Pine.LNX.4.58.0409111042580.1315@xxxxxxxxxxxx> <20040912170323.65eadc38.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040818i
On Sun, Sep 12, 2004 at 05:03:23PM -0700, David S. Miller wrote:
> On Sat, 11 Sep 2004 10:53:53 +0300 (EEST)
> Julian Anastasov <ja@xxxxxx> wrote:
> 
> >     This is a resend/resync for v2.6.9-rc1-bk17: change the
> > way the ip_nat_ftp helper manipulates the packets:
> > 
> > - no manips => no fixup
> > 
> > - check the direction, do manip once and at the same time when the
> > headers are changed
> > 
> >     This is needed mostly for IPVS setups and I hope we do not
> > create troubles for other setups or FTP software.
> > 
> > Signed-off-by: Julian Anastasov <ja@xxxxxx>
> 
> Harald and/or Rusty, please ACK/NACK this for me.

I agree with the change (although I didn't test it here on my systems so
far).  However, as indicated in private mail to Julian, the change
should be made consistent over all helpers.

So please hold back the patch until I get back to you, thanks.

> Thanks.

-- 
- Harald Welte <laforge@xxxxxxxxxxxxx>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>