netdev
[Top] [All Lists]

Re: [PATCH] Fix locking bug in lltx path

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] Fix locking bug in lltx path
From: Andi Kleen <ak@xxxxxxx>
Date: Mon, 13 Sep 2004 21:26:49 +0200
Cc: Andi Kleen <ak@xxxxxx>, netdev@xxxxxxxxxxx, arjanv@xxxxxxxxxx
In-reply-to: <20040913121859.44fbf949.davem@xxxxxxxxxx>
References: <m3vfei9gzv.fsf@xxxxxxxxxxxxxxxxxxxxxx> <20040913121859.44fbf949.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, Sep 13, 2004 at 12:18:59PM -0700, David S. Miller wrote:
> On Mon, 13 Sep 2004 20:11:00 +0200
> Andi Kleen <ak@xxxxxx> wrote:
> 
> > Thanks to Arjan's spinlock debug kernel for finding it.
> > 
> > This fixes a silly missing spin lock in the relock path. For some 
> > reason it seems to still work when you don't have spinlock debugging
> > enabled.
> > 
> > Please apply.
> 
> Good catch, but I'll need to fix this up to use the new macros
> defined in linux/netdevice.h

Ok, do you want me to send a new patch with that? 

I don't think the new macros are in -bk* snapshots yet,
and getting it otherwise is difficult for me.

It's probably fastest if you just apply it by hand.

-Andi

<Prev in Thread] Current Thread [Next in Thread>