| To: | davem@xxxxxxxxxx |
|---|---|
| Subject: | [PATCH] Fix locking bug in lltx path |
| From: | Andi Kleen <ak@xxxxxx> |
| Date: | Mon, 13 Sep 2004 20:11:00 +0200 |
| Cc: | netdev@xxxxxxxxxxx, arjanv@xxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Gnus/5.110003 (No Gnus v0.3) Emacs/21.2 (gnu/linux) |
Thanks to Arjan's spinlock debug kernel for finding it.
This fixes a silly missing spin lock in the relock path. For some
reason it seems to still work when you don't have spinlock debugging
enabled.
Please apply.
-Andi
--------------------------------------------------------------------
Fix missing spin lock in lltx path.
Thanks to Arjan's spinlock debug kernel for finding it.
Signed-off-by: Andi Kleen <ak@xxxxxx>
diff -u linux-2.6.9rc1-bk19/net/sched/sch_generic.c-X
linux-2.6.9rc1-bk19/net/sched/sch_generic.c
--- linux-2.6.9rc1-bk19/net/sched/sch_generic.c-X 2004-09-13
08:51:46.000000000 +0200
+++ linux-2.6.9rc1-bk19/net/sched/sch_generic.c 2004-09-13 19:22:50.000000000
+0200
@@ -153,8 +153,10 @@
spin_lock(&dev->queue_lock);
return -1;
}
- if (ret == -1 && nolock)
+ if (ret == -1 && nolock) {
+ spin_lock(&dev->queue_lock);
goto collision;
+ }
}
/* Release the driver */
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] linux 2.6.x.x - include/net/neighbour.h spell-check, S P |
|---|---|
| Next by Date: | Re: hard_start_xmit and Linux bridging, Ben Greear |
| Previous by Thread: | [PATCH] linux 2.6.x.x - include/net/neighbour.h spell-check, S P |
| Next by Thread: | Re: [PATCH] Fix locking bug in lltx path, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |