netdev
[Top] [All Lists]

Re: [PATCH] NETIF_F_LLTX for devices 2

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [PATCH] NETIF_F_LLTX for devices 2
From: Andi Kleen <ak@xxxxxxx>
Date: Mon, 13 Sep 2004 08:59:58 +0200
Cc: Andi Kleen <ak@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, hadi@xxxxxxxxxx, herbert@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040912161604.GA23366@xxxxxxxxxxxxx>
References: <20040908072408.GI27886@xxxxxxxxxxxxx> <1094629677.1089.155.camel@xxxxxxxxxxxxxxxx> <20040908134713.1bcd46d3.davem@xxxxxxxxxxxxx> <1094823215.1121.129.camel@xxxxxxxxxxxxxxxx> <20040911142116.GL4431@xxxxxxxxxxxxx> <1094933731.2343.109.camel@xxxxxxxxxxxxxxxx> <20040911174535.2acbb957.davem@xxxxxxxxxxxxx> <20040912100114.GB11484@xxxxxxxxxxxxx> <20040912102529.GA27096@xxxxxxxxxxxxx> <20040912161604.GA23366@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, Sep 12, 2004 at 12:16:05PM -0400, Jeff Garzik wrote:
> Incorrect, you are changing the callsites, which -does- affect every
> driver.

Please read the code before making such claims. 

The new return code is _only_ checked when NETIF_F_LLTX is set. 
A driver that doesn't set this new flag won't ever recognize 
any difference.

-Andi

<Prev in Thread] Current Thread [Next in Thread>