| To: | hadi@xxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH] NETIF_F_LLTX for devices 2 |
| From: | Andrew Grover <andy.grover@xxxxxxxxx> |
| Date: | Sun, 12 Sep 2004 19:52:43 -0700 |
| Cc: | Jeff Garzik <jgarzik@xxxxxxxxx>, Andi Kleen <ak@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, herbert@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <1095010469.2344.215.camel@xxxxxxxxxxxxxxxx> |
| References: | <E1C4wYe-0005qT-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20040908134713.1bcd46d3.davem@xxxxxxxxxxxxx> <1094823215.1121.129.camel@xxxxxxxxxxxxxxxx> <20040911142116.GL4431@xxxxxxxxxxxxx> <1094933731.2343.109.camel@xxxxxxxxxxxxxxxx> <20040911174535.2acbb957.davem@xxxxxxxxxxxxx> <20040912100114.GB11484@xxxxxxxxxxxxx> <20040912102529.GA27096@xxxxxxxxxxxxx> <20040912161604.GA23366@xxxxxxxxxxxxx> <1095010469.2344.215.camel@xxxxxxxxxxxxxxxx> |
| Reply-to: | Andrew Grover <andy.grover@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On 12 Sep 2004 13:34:30 -0400, jamal <hadi@xxxxxxxxxx> wrote: > On Sun, 2004-09-12 at 12:16, Jeff Garzik wrote: > > Thanks, but still need a patch for return value constants, otherwise you > > are compounding rather than addressing a current problem. > > Something along the lines of attached patch? > Francois needs to update the doc and you need someone to get the > janitors enthusiastic (i just updated e1000) +#define NETDEV_TX_OK 0 /* driver took care of packet */ +#define NETDEV_TX_BUSY 1 /* driver tx path was busy*/ +#define NETDEV_TX_LOCKED -1 /* driver tx lock was already taken */ Why is TX_LOCKED -1 instead of, say, 2? (The actual values are now irrelevant, right? Non sequential consts makes one think their value is still important in some way. Maybe it's just me.) -- Andy |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | ICMP attacks against TCP, Fernando Gont |
|---|---|
| Next by Date: | [PATCHES] via-velocity fixes, Tejun Heo |
| Previous by Thread: | Re: [PATCH] NETIF_F_LLTX for devices 2, David S. Miller |
| Next by Thread: | Re: [PATCH] NETIF_F_LLTX for devices 2, Andi Kleen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |