Re: [PATCH] [NETFILTER] Fix "undefined reference" error if CONFIG_SYSCTL=n

[YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>]

In article <20040910.153135.121099678.yoshfuji@xxxxxxxxxxxxxx> (at Fri, 10 Sep 
2004 15:31:35 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx> 
says:

> +unsigned int ip_ct_log_invalid = 0;
> +
>  static int kill_proto(const struct ip_conntrack *i, void *data)
>  {
>       return (i->tuplehash[IP_CT_DIR_ORIGINAL].tuple.dst.protonum == 
> @@ -522,7 +524,6 @@
>  extern unsigned long ip_ct_generic_timeout;
>  
>  /* Log invalid packets of a given protocol */
> -unsigned int ip_ct_log_invalid = 0;
>  static int log_invalid_proto_min = 0;
>  static int log_invalid_proto_max = 255;

Or, you may prefer to move related things as well.

Signed-off-by: Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>

===== net/ipv4/netfilter/ip_conntrack_standalone.c 1.40 vs edited =====
--- 1.40/net/ipv4/netfilter/ip_conntrack_standalone.c   2004-09-01 00:27:37 
+09:00
+++ edited/net/ipv4/netfilter/ip_conntrack_standalone.c 2004-09-10 15:32:44 
+09:00
@@ -48,6 +48,11 @@
 extern atomic_t ip_conntrack_count;
 DECLARE_PER_CPU(struct ip_conntrack_stat, ip_conntrack_stat);
 
+/* Log invalid packets of a given protocol */
+unsigned int ip_ct_log_invalid = 0;
+static int log_invalid_proto_min = 0;
+static int log_invalid_proto_max = 255;
+
 static int kill_proto(const struct ip_conntrack *i, void *data)
 {
        return (i->tuplehash[IP_CT_DIR_ORIGINAL].tuple.dst.protonum == 
@@ -520,11 +525,6 @@
 
 /* From ip_conntrack_proto_icmp.c */
 extern unsigned long ip_ct_generic_timeout;
-
-/* Log invalid packets of a given protocol */
-unsigned int ip_ct_log_invalid = 0;
-static int log_invalid_proto_min = 0;
-static int log_invalid_proto_max = 255;
 
 static struct ctl_table_header *ip_ct_sysctl_header;
 

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA