netdev
[Top] [All Lists]

Re: [PATCH 2.6 NET] Adjust RTATTR_MAX to IFLA_* changes

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2.6 NET] Adjust RTATTR_MAX to IFLA_* changes
From: Thomas Graf <tgraf@xxxxxxx>
Date: Thu, 9 Sep 2004 19:49:43 +0200
Cc: hadi@xxxxxxxxxx, eric.lemoine@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040909103149.248a603e.davem@xxxxxxxxxxxxx>
References: <20040909163131.GA18951@xxxxxxxxxxxxxx> <20040909103149.248a603e.davem@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
* David S. Miller <20040909103149.248a603e.davem@xxxxxxxxxxxxx> 2004-09-09 10:31
> On Thu, 9 Sep 2004 18:31:31 +0200
> Thomas Graf <tgraf@xxxxxxx> wrote:
> 
> > IFLA_MAX is now bigger than RTA_MAX with the latest changes in IFLA_*.
> > Adjust RTATTR to point to IFLA_MAX to have big enough buffer in
> > rtnetlink_rcv_msg.
> 
> Ok, this is going to get silly if some other attribute gets
> larger than IFLA_* next.
> 
> We should just compute this thing at run time.
> Else, if the macro can't be deleted because there
> are non-trivial other uses, use some expression
> involving max().
> 
> I just checked iproute2 sources and it does not reference
> this thing, so probably best to kill it off, like so.

This is even better, works fine for me.

<Prev in Thread] Current Thread [Next in Thread>