netdev
[Top] [All Lists]

Re: PPP-over-L2TP kernel support, patch for review

To: James Chapman <jchapman@xxxxxxxxxxx>
Subject: Re: PPP-over-L2TP kernel support, patch for review
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 7 Sep 2004 15:56:57 -0700
Cc: netdev@xxxxxxxxxxx, kleptog@xxxxxxxxx
In-reply-to: <1094471956.413c5114de2d7@xxxxxxxxxxxxxxx>
References: <1094471956.413c5114de2d7@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon,  6 Sep 2004 12:59:16 +0100
James Chapman <jchapman@xxxxxxxxxxx> wrote:

> I'm working towards having this driver integrated into the kernel
> tree. Comments?

Only two major comments:

1) Uses own linked list implementations.  Please use
   linux/list.h interfaces for this.

2) Does this:

 struct sockaddr_pppox { 
        sa_family_t     sa_family;            /* address family, AF_PPPOX */ 
        unsigned int    sa_protocol;          /* protocol identifier */ 
        union{ 
                struct pppoe_addr       pppoe; 
+               struct pppol2tp_addr    pppol2tp;
        }sa_addr; 
 }__attribute__ ((packed)); 

   Change the size of sockaddr_pppox on any platform?  If so, you'll
   break pppox userspace with this change so we'd need find another
   way to do it.

Thanks.

<Prev in Thread] Current Thread [Next in Thread>